Aarchy commented on code in PR #1690:
URL: https://github.com/apache/phoenix/pull/1690#discussion_r1411943717
##########
phoenix-coprocessors/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java:
##########
@@ -210,7 +210,7 @@ public InternalScanner
preCompact(ObserverContext<RegionCoprocessorEnvironment>
InternalScanner s, ScanType scanType, CompactionLifeCycleTracker
tracker,
CompactionRequest request) throws IOException {
- if (!IndexUtil.isLocalIndexStore(store)) { return s; }
Review Comment:
I think Store is defined in hbase-server package, IndexUtil is in
phoenix-core. We want to break (phoenix-core -> hbase-server) dependency so
this function needs to be moved. As its only used in this file, which is indeed
in pheonix-coprocessors (which can use hbase-server), I moved it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
