stoty commented on code in PR #1690:
URL: https://github.com/apache/phoenix/pull/1690#discussion_r1412014916
##########
phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java:
##########
@@ -1078,16 +1031,17 @@ public static int getAutoPartitionColIndex(PTable
parentTable) {
return (isMultiTenant && isSalted) ? 2 : (isMultiTenant || isSalted) ?
1 : 0;
}
- public static String getJdbcUrl(RegionCoprocessorEnvironment env) {
- String zkQuorum =
env.getConfiguration().get(HConstants.ZOOKEEPER_QUORUM);
- String zkClientPort =
env.getConfiguration().get(HConstants.ZOOKEEPER_CLIENT_PORT,
- Integer.toString(HConstants.DEFAULT_ZOOKEEPER_CLIENT_PORT));
- String zkParentNode =
env.getConfiguration().get(HConstants.ZOOKEEPER_ZNODE_PARENT,
- HConstants.DEFAULT_ZOOKEEPER_ZNODE_PARENT);
- return PhoenixRuntime.JDBC_PROTOCOL +
PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkQuorum
- + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkClientPort
- + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkParentNode;
- }
+ //TODO
Review Comment:
Dead functions can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
