jpisaac commented on code in PR #1875:
URL: https://github.com/apache/phoenix/pull/1875#discussion_r1575485629
##########
pom.xml:
##########
@@ -405,6 +405,42 @@
<goal>verify</goal>
</goals>
</execution>
+ <execution>
+ <id>SignOffTests</id>
+ <configuration>
+ <reuseForks>false</reuseForks>
+ <argLine>@{jacocoArgLine} -enableassertions -Xmx3000m
-Djava.security.egd=file:/dev/./urandom
"-Djava.library.path=${hadoop.library.path}${path.separator}${java.library.path}"
-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/ -XX:NewRatio=4
-XX:SurvivorRatio=8 -XX:+UseCompressedOops -XX:+UseConcMarkSweepGC
-XX:+DisableExplicitGC -XX:+UseCMSInitiatingOccupancyOnly
-XX:+CMSClassUnloadingEnabled -XX:+CMSScavengeBeforeRemark
-XX:CMSInitiatingOccupancyFraction=68</argLine>
+
<groups>org.apache.phoenix.end2end.SupportsDistributedClusterTest</groups>
Review Comment:
What category is SupportsDistributedClusterTest? How is it different from
SuccessfulSupportsDistributedClusterTest?
Or is the intent to use one or the other? In that case I would vote for
"SupportsDistributedClusterTest"
##########
phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java:
##########
@@ -975,10 +999,54 @@ private static void deletePriorTables(long ts, Connection
globalConn, String url
ResultSet rs = dbmd.getTables(null, null, null, tableTypes);
String lastTenantId = null;
Connection conn = globalConn;
+ System.out.println("outside");
Review Comment:
nit: Remember to remove these debug lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
