jpisaac commented on code in PR #1875:
URL: https://github.com/apache/phoenix/pull/1875#discussion_r1643185144
##########
phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java:
##########
@@ -454,8 +455,10 @@ protected static String
checkClusterInitialized(ReadOnlyProps serverProps) throw
protected static String setUpTestCluster(@Nonnull Configuration conf,
ReadOnlyProps overrideProps) throws Exception {
boolean isDistributedCluster = isDistributedClusterModeEnabled(conf);
if (!isDistributedCluster) {
+ TEARDOWN_THRESHOLD.set(30);
return initMiniCluster(conf, overrideProps);
} else {
+ TEARDOWN_THRESHOLD.set(1);
Review Comment:
> Do we need to clear up after each test ? A Real cluster should have enough
resources to hold some leftover tables.
The cleanup logic is more simpler. Else we will need to track the tables
created per jvm and then clean them up based on revised thresholds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
