jpisaac commented on code in PR #1875: URL: https://github.com/apache/phoenix/pull/1875#discussion_r1638706858
########## phoenix-core/src/it/java/org/apache/phoenix/end2end/FailedSupportsDistributedClusterTest.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you maynot use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicablelaw or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.end2end; + +/** + * + * Marker class to denote that the test needs to run its own + * mini cluster that is separate from the clusters used by + * tests annotated as {@link ParallelStatsDisabledTest} or + * {@link ParallelStatsEnabledTest}. + * + * As much as possible, tests should be able to run in one of the + * mini clusters used by {@link ParallelStatsDisabledTest} or + * {@link ParallelStatsEnabledTest}. In the *rare* case it can't + * you would need to annotate the test as {@link NeedsOwnMiniClusterTest} + * otherwise the test won't be executed when you run mvn verify or mvn install. + * + * @since 4.1 + */ +public class FailedSupportsDistributedClusterTest { Review Comment: nit: inline with SupportsDistributedClusterTest naming convention, it would make sense this interface to be named DoesNotSupportDistributedClusterTest. ########## phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java: ########## @@ -771,15 +775,22 @@ protected ResultSet executeQuery(Connection conn, QueryBuilder queryBuilder) thr * Note, we can't have this value too high since we don't want the shutdown to take too * long a time either. */ - private static final int TEARDOWN_THRESHOLD = 30; + private static final AtomicInteger TEARDOWN_THRESHOLD = new AtomicInteger(0); + + @ClassRule + public static PhoenixTestTableName phoenixTestTableName = new PhoenixTestTableName(); public static String generateUniqueName() { int nextName = NAME_SUFFIX.incrementAndGet(); if (nextName >= MAX_SUFFIX_VALUE) { throw new IllegalStateException("Used up all unique names"); } TABLE_COUNTER.incrementAndGet(); - return "N" + Integer.toString(MAX_SUFFIX_VALUE + nextName).substring(1); + if(!isDistributedClusterModeEnabled(config)){ Review Comment: nit: space after "if" and before "{" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
