virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1578651771
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##########
@@ -720,6 +726,402 @@ public void testMultiplePartialUpdatesInSameBatch()
throws Exception {
}
}
+ @Test
+ public void testColumnsTimestampUpdateWithAllCombinations() throws
Exception {
Review Comment:
`testColumnsTimestampUpdateWithAllCombinations()` and
`testColumnsTimestampUpdateWithIntentionalUpdate()` are the only tests that
don't need to be ignored because we are not asserting return status?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
