tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1600414682
##########
phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1366,6 +1375,7 @@ private void sendMutations(Iterator<Entry<TableInfo,
List<Mutation>>> mutationsI
while (itrListMutation.hasNext()) {
final List<Mutation> mutationBatch =
itrListMutation.next();
currentMutationBatch = mutationBatch;
+ Object[] resultObjects = new
Object[mutationBatch.size()];
Review Comment:
I see that we are only reading resultObjects if autocommit is set to true.
So we should only allocate this object when autocommit is set. If the
autocommit is not set the batch size can be 100s to 1000s and we are just
wasting memory by allocating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
