tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1600458514
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java:
##########
@@ -568,13 +568,18 @@ public Integer call() throws SQLException {
checkIfDDLStatementandMutationState(stmt,
state);
MutationState lastState = plan.execute();
state.join(lastState);
+ // Unfortunately, JDBC uses an int for update
count, so we
+ // just max out at Integer.MAX_VALUE
+ int lastUpdateCount = (int)
Math.min(Integer.MAX_VALUE,
+ lastState.getUpdateCount());
if (connection.getAutoCommit()) {
connection.commit();
+ if (isAtomicUpsert) {
+ lastUpdateCount =
connection.getMutationState()
+
.getNumUpdatedRowsForAutoCommit();
+ }
Review Comment:
If you do the `numRowsIgnored` suggestion I stated above then we don't need
to change anything here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
