tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1600561429
##########
phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1415,8 +1425,23 @@ public List<Mutation> getMutationList() {
}, iwe, connection,
connection.getQueryServices().getProps());
shouldRetryIndexedMutation = false;
} else {
- hTable.batch(mutationBatch, null);
+ hTable.batch(mutationBatch, resultObjects);
+ }
+
+ if (connection.getAutoCommit()) {
+ for (int i = 0; i < mutationBatch.size(); i++) {
+ Result result = (Result) resultObjects[i];
+ if (result != null && !result.isEmpty()) {
+ Cell cell = result.rawCells()[0];
+ numUpdatedRowsForAutoCommit =
PInteger.INSTANCE.getCodec()
Review Comment:
Actually, we need to think more carefully about the client side changes. The
code written so far is only handling auto-commit on a batch of size 1. It will
not work when there is a batch of atomic upserts with auto-commit set to true.
See [PHOENIX-6821](https://issues.apache.org/jira/browse/PHOENIX-6821)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
