virajjasani commented on code in PR #2060:
URL: https://github.com/apache/phoenix/pull/2060#discussion_r1924497825
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseRowKeyMatcherTestIT.java:
##########
@@ -183,6 +194,15 @@ private Object getData(PDataType type) {
case Types.TIMESTAMP:
//pkTypeStr = "TIMESTAMP";
return new Timestamp(System.currentTimeMillis() +
rnd.nextInt(50000));
+ case Types.VARBINARY:
+ // pkTypeStr = "VARBINARY";
+ case 9000:
Review Comment:
same here: `PDataType.VARBINARY_ENCODED_TYPE`
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseRowKeyMatcherTestIT.java:
##########
@@ -153,6 +158,12 @@ private String getType(PDataType pkType) {
case Types.TIMESTAMP:
pkTypeStr = "TIMESTAMP";
break;
+ case Types.VARBINARY:
+ pkTypeStr = "VARBINARY";
+ break;
+ case 9000:
Review Comment:
nit: `PDataType.VARBINARY_ENCODED_TYPE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
