virajjasani commented on code in PR #2060:
URL: https://github.com/apache/phoenix/pull/2060#discussion_r1924499217
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseRowKeyMatcherTestIT.java:
##########
@@ -320,12 +344,16 @@ private Pair<String, byte[]> createTenantView(boolean
extendPK, int partition,
"CONSTRAINT pk PRIMARY KEY (ZID)) " + "AS
SELECT * FROM %s %s %s";
String VIEW_WO_PK_TEMPLATE = "CREATE VIEW IF NOT EXISTS %s AS
SELECT * from %s %s";
if (extendPK) {
- cstmt.execute(
+ String viewWithPKSQL =
String.format(VIEW_WITH_PK_TEMPLATE,
tenantViewName, globalViewName,
- getWhereClause(pkNames, pkTypes),
tenantViewOptions));
+ getWhereClause(pkNames, pkTypes),
tenantViewOptions);
+ LOGGER.info(String.format("Created tenant view (WITH_PK)
%s", viewWithPKSQL));
Review Comment:
nit: `LOGGER.info("Created tenant view (WITH_PK) {}", viewWithPKSQL)`
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseRowKeyMatcherTestIT.java:
##########
@@ -271,17 +291,21 @@ private Pair<String, byte[]> createGlobalView(String
tableName, int partition,
"CONSTRAINT pk PRIMARY KEY (ID1 %s, ID2 %s,
ID3 %s, ROW_ID)) " +
"AS SELECT * FROM %s WHERE KP = '%s'";
- cstmt.execute(String.format(VIEW_TEMPLATE, globalViewName,
pkType1Str, pkType2Str,
+ String globalViewSQL = String.format(VIEW_TEMPLATE,
globalViewName, pkType1Str, pkType2Str,
pkType3Str, pkOrders[0].name(), pkOrders[1].name(),
pkOrders[2].name(),
- baseTableName, partitionName));
+ baseTableName, partitionName);
+ LOGGER.info(String.format("Created global view %s",
globalViewSQL));
Review Comment:
nit: `LOGGER.info("Created global view {}", globalViewSQL)`
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseRowKeyMatcherTestIT.java:
##########
@@ -320,12 +344,16 @@ private Pair<String, byte[]> createTenantView(boolean
extendPK, int partition,
"CONSTRAINT pk PRIMARY KEY (ZID)) " + "AS
SELECT * FROM %s %s %s";
String VIEW_WO_PK_TEMPLATE = "CREATE VIEW IF NOT EXISTS %s AS
SELECT * from %s %s";
if (extendPK) {
- cstmt.execute(
+ String viewWithPKSQL =
String.format(VIEW_WITH_PK_TEMPLATE,
tenantViewName, globalViewName,
- getWhereClause(pkNames, pkTypes),
tenantViewOptions));
+ getWhereClause(pkNames, pkTypes),
tenantViewOptions);
+ LOGGER.info(String.format("Created tenant view (WITH_PK)
%s", viewWithPKSQL));
+ cstmt.execute(viewWithPKSQL);
} else {
- cstmt.execute(String.format(VIEW_WO_PK_TEMPLATE,
tenantViewName, globalViewName,
- tenantViewOptions));
+ String viewWithoutPKSQL =
String.format(VIEW_WO_PK_TEMPLATE, tenantViewName, globalViewName,
+ tenantViewOptions);
+ LOGGER.info(String.format("Created tenant view ((WO_PK))
%s", viewWithoutPKSQL));
Review Comment:
same here
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseRowKeyMatcherTestIT.java:
##########
@@ -271,17 +291,21 @@ private Pair<String, byte[]> createGlobalView(String
tableName, int partition,
"CONSTRAINT pk PRIMARY KEY (ID1 %s, ID2 %s,
ID3 %s, ROW_ID)) " +
"AS SELECT * FROM %s WHERE KP = '%s'";
- cstmt.execute(String.format(VIEW_TEMPLATE, globalViewName,
pkType1Str, pkType2Str,
+ String globalViewSQL = String.format(VIEW_TEMPLATE,
globalViewName, pkType1Str, pkType2Str,
pkType3Str, pkOrders[0].name(), pkOrders[1].name(),
pkOrders[2].name(),
- baseTableName, partitionName));
+ baseTableName, partitionName);
+ LOGGER.info(String.format("Created global view %s",
globalViewSQL));
+ cstmt.execute(globalViewSQL);
if (hasGlobalViewIndexes) {
String indexNamePrefix = String.format("G%s", partition);
String
GLOBAL_INDEX_TEMPLATE =
"CREATE INDEX IF NOT EXISTS %s_COL2_INDEX ON %s
(COL2) " +
"INCLUDE(SYSTEM_MODSTAMP)";
- cstmt.execute(
- String.format(GLOBAL_INDEX_TEMPLATE,
indexNamePrefix, globalViewName));
+ String globalViewIndexSQL =
+ String.format(GLOBAL_INDEX_TEMPLATE,
indexNamePrefix, globalViewName);
+ LOGGER.info(String.format("Created global view index %s",
globalViewIndexSQL));
Review Comment:
same here, String.format not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
