jpisaac commented on code in PR #2060:
URL: https://github.com/apache/phoenix/pull/2060#discussion_r1924500434
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseViewTTLIT.java:
##########
@@ -2347,14 +2478,178 @@ protected void
testMajorCompactWithVariousTenantIdTypesAndRegions(PDataType tena
}
+ protected void testMajorCompactTenantViewsWithVariousPKTypesAndSortOrder()
throws Exception {
+ try {
+ List<PDataType[]> testCases = getTestCases();
+ SortOrder[][] sortOrders = getSortOrders();
+ for (PDataType[] aCase : testCases) {
+ for (SortOrder[] sortOrder : sortOrders) {
+ runTenantViewsWithVariousPKTypes(aCase, sortOrder);
+ }
+ }
+ } catch (Exception e) {
+ LOGGER.info(LogUtil.getCallerStackTrace());
+ LOGGER.error(e.getMessage());
+ }
+
+ }
+
+ /**
+ * Test special case:
+ * Test with various PK Types and SortOrders
+ * This can occur when the TENANT_ID and global view PARTITION_KEY overlap.
+ * @throws Exception
+ */
+
+ private void runTenantViewsWithVariousPKTypes(PDataType[] pkDataTypes,
SortOrder[] sortOrders) throws Exception {
+ // View TTL is set in seconds (for e.g 10 secs)
+ resetEnvironmentEdgeManager();
+ int viewTTL = VIEW_TTL_10_SECS;
+ // Define the test schema.
+ // 1. Table with columns => (ORG_ID, KP, COL1, COL2, COL3), PK =>
(ORG_ID, KP)
+ // 2. GlobalView with columns => (ID, COL4, COL5, COL6), PK => (ID)
Review Comment:
Update comments with actual column names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
