haridsv commented on PR #2199: URL: https://github.com/apache/phoenix/pull/2199#issuecomment-3001227280
In fact, there is one less if condition now because there is only one variable. The change is based on two facts, 1) there is only one version that you are returning, so why have 2 variables, especially that only one of them is ever going to be non-null, 2) chronologically, you come across the old version first so take a note of it and use it unless a new version is available. To me this feels way more cleaner even without any verbs to wrap the if conditions (there are simple enough with just one or two conditions only), but I will leave the decision up to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
