virajjasani commented on PR #2199:
URL: https://github.com/apache/phoenix/pull/2199#issuecomment-3001209133
```
- } else if (context.returnResult) {
+ } else if (context.returnResult && !context.returnOldRow) {
Map<ColumnReference, Pair<Cell, Boolean>>
currColumnCellExprMap = new HashMap<>();
byte[] rowKey = m.getRow();
ImmutableBytesPtr rowKeyPtr = new ImmutableBytesPtr(rowKey);
```
This means DELETE cannot return old row even if someone uses oldRow return
API.
Anyways, these too are debatable mechanical changes that we can do but I am
bit hesitant only because the logic becomes more complicated to understand for
anyone. When someone looks at separate map, it becomes way easier to track it's
limited usage and find out how the server is returning old row vs new row,
rather than debugging through 5 extra conditional checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
