MonkeyCanCode opened a new pull request, #386:
URL: https://github.com/apache/polaris/pull/386
# Description
The current Helm chart doesn’t allow customization of the
revisionHistoryLimit parameter, which is crucial for controlling the number of
ReplicaSets retained for K8S deployment. This PR introduces the ability to set
revisionHistoryLimit in the values file, defaulting to the standard value if
not specified.
Also, I cleanup one comment in ingress.yaml which is not needed.
## Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Documentation update
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] This change requires a documentation update
# How Has This Been Tested?
When revisionHistoryLimit is not set:
```sh
xxx@DESKTOP:~/k8s/polaris/helm/polaris(add_revisionHistoryLimit)$ cat
myvalues.yaml | grep revision
revisionHistoryLimit: ~
xxx@DESKTOP:~/k8s/polaris/helm/polaris(add_revisionHistoryLimit)$ helm
template polaris -f myvalues.yaml . | grep revision
walk.go:74: found symbolic link in path:
/home/yong/k8s/polaris/helm/polaris/LICENSE resolves to
/home/yong/k8s/polaris/LICENSE. Contents of linked file included and used
```
When revisionHistoryLimit is set to 0:
```
xxx@DESKTOP:~/k8s/polaris/helm/polaris(add_revisionHistoryLimit)$ cat
myvalues.yaml | grep revision
revisionHistoryLimit: 0
xxx@DESKTOP:~/k8s/polaris/helm/polaris(add_revisionHistoryLimit)$ helm
template polaris -f myvalues.yaml . | grep revision
walk.go:74: found symbolic link in path:
/home/yong/k8s/polaris/helm/polaris/LICENSE resolves to
/home/yong/k8s/polaris/LICENSE. Contents of linked file included and used
revisionHistoryLimit: 0
```
When revisionHistoryLimit is set to 1:
```sh
xxx@DESKTOP:~/k8s/polaris/helm/polaris(add_revisionHistoryLimit)$ cat
myvalues.yaml | grep revision
revisionHistoryLimit: 1
xxx@DESKTOP:~/k8s/polaris/helm/polaris(add_revisionHistoryLimit)$ helm
template polaris -f myvalues.yaml . | grep revision
walk.go:74: found symbolic link in path:
/home/yong/k8s/polaris/helm/polaris/LICENSE resolves to
/home/yong/k8s/polaris/LICENSE. Contents of linked file included and used
revisionHistoryLimit: 1
```
# Checklist:
Please delete options that are not relevant.
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
