adutra commented on code in PR #386:
URL: https://github.com/apache/polaris/pull/386#discussion_r1810977687
##########
helm/polaris/templates/deployment.yaml:
##########
@@ -31,6 +31,9 @@ spec:
{{- if not .Values.autoscaling.enabled }}
replicas: {{ .Values.replicaCount }}
{{- end }}
+ {{- if not (has (quote .Values.revisionHistoryLimit) (list "" (quote ""))) }}
Review Comment:
@MonkeyCanCode we just merged support for helm-unit. If you update your
branch, maybe you could add a small unit test for this field? Especially for
the logic around differentiating `0` from `nil` or `""`. Thanks 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
