MonkeyCanCode commented on code in PR #386:
URL: https://github.com/apache/polaris/pull/386#discussion_r1811641645
##########
helm/polaris/templates/deployment.yaml:
##########
@@ -31,6 +31,9 @@ spec:
{{- if not .Values.autoscaling.enabled }}
replicas: {{ .Values.replicaCount }}
{{- end }}
+ {{- if not (has (quote .Values.revisionHistoryLimit) (list "" (quote ""))) }}
Review Comment:
@adutra this had being added. I really like this approach with validating
helm (compared to how I was doing it earlier via helm template). I can add the
remaining test cases in for the next PR if there is no concern on your end and
no one is already working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
