dennishuo opened a new pull request, #404: URL: https://github.com/apache/polaris/pull/404
Add a --base-url argument that can be used instead of --host --port to support arbitrary Polaris URLs including https ones that have additional base prefixes before the /api/*/v1 subpaths. Fix namespaces.py to parse such URLs as well. Fix `catalogs update` to explicitly preserve default-base-location in the update request and use dict merge semantics for specified properties instead of just replacing the entire catalog contents with only what's specified in cli arguments, otherwise default-base-location or other properties get clobbered unexpectedly. Make the test_cli.py abide by POLARIS_HOST so that it can be pointed at a basic `./gradlew runApp` with `POLARIS_HOST=localhost` even without a docker container. Add tests for updating catalog properties. # Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Documentation update - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [ ] Test A - [ ] Test B **Test Configuration**: * Hardware: * Toolchain: * SDK: # Checklist: Please delete options that are not relevant. - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
