dennishuo commented on code in PR #404:
URL: https://github.com/apache/polaris/pull/404#discussion_r1815967221
##########
regtests/client/python/cli/polaris_cli.py:
##########
@@ -36,9 +37,12 @@ class PolarisCli:
available in the Python client API.
Example usage:
- * ./polaris --client-id ${id} --client-secret ${secret} --host ${hostname}
principals create example_user
- * ./polaris --client-id ${id} --client-secret ${secret} --host ${hostname}
principal-roles create example_role
- * ./polaris --client-id ${id} --client-secret ${secret} --host ${hostname}
catalog-roles list
+ * ./polaris --client-id ${id} --client-secret ${secret} --host ${hostname}
--port ${port} principals create example_user
Review Comment:
Ah, this was a typo, was only supposed to add a single example. Fixed.
##########
regtests/client/python/cli/polaris_cli.py:
##########
@@ -108,8 +112,13 @@ def _get_client_builder(options):
f' Alternatively, you may set the environment
variables {CLIENT_ID_ENV} &'
f' {CLIENT_SECRET_ENV}.')
# Authenticate accordingly
- polaris_management_url =
f'http://{options.host}:{options.port}/api/management/v1'
- polaris_catalog_url =
f'http://{options.host}:{options.port}/api/catalog/v1'
+ if options.base_url:
+ polaris_management_url = f'{options.base_url}/api/management/v1'
+ polaris_catalog_url = f'{options.base_url}/api/catalog/v1'
+ else:
Review Comment:
Done
##########
regtests/t_cli/src/test_cli.py:
##########
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
