dennishuo commented on code in PR #404:
URL: https://github.com/apache/polaris/pull/404#discussion_r1820036498
##########
regtests/client/python/cli/polaris_cli.py:
##########
@@ -20,6 +20,7 @@
import json
import os
import sys
+import traceback
Review Comment:
Removed
##########
regtests/t_cli/src/test_cli.py:
##########
@@ -29,7 +29,8 @@
CLI_PYTHONPATH =
f'{os.path.dirname(os.path.abspath(__file__))}/../../client/python'
ROLE_ARN = 'arn:aws:iam::123456789012:role/my-role'
-POLARIS_URL = 'http://polaris:8181/api/catalog/v1/oauth/tokens'
+POLARIS_HOST = os.getenv('POLARIS_HOST') or 'polaris'
Review Comment:
`POLARIS_HOST` is actually already set in the Dockerfile and used by various
tests under `t_spark_sql` and `t_pyspark`. I agree the overall regtests setup
could probably use more extensive documentation though.
##########
regtests/client/python/cli/command/catalogs.py:
##########
@@ -176,22 +176,29 @@ def execute(self, api: PolarisDefaultApi) -> None:
print(catalog.to_json())
elif self.catalogs_subcommand == Subcommands.UPDATE:
catalog = api.get_catalog(self.catalog_name)
+
if self.default_base_location or self.properties:
+ new_default_base_location = self.default_base_location or
catalog.properties.default_base_location
+ new_additional_properties =
catalog.properties.additional_properties.copy()
+ if self.properties:
+ new_additional_properties.update(self.properties)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
