jbonofre commented on code in PR #423:
URL: https://github.com/apache/polaris/pull/423#discussion_r1829423900
##########
polaris-service/src/main/java/org/apache/polaris/service/PolarisApplication.java:
##########
@@ -261,10 +261,7 @@ public void run(PolarisApplicationConfig configuration,
Environment environment)
.addMappingForUrlPatterns(EnumSet.of(DispatcherType.REQUEST), true,
"/*");
if (configuration.getRateLimiter() != null) {
- environment
- .servlets()
- .addFilter("ratelimiter", new
RateLimiterFilter(configuration.getRateLimiter()))
- .addMappingForUrlPatterns(EnumSet.of(DispatcherType.REQUEST), true,
"/*");
+ environment.jersey().register(new
RateLimiterFilter(configuration.getRateLimiter()));
Review Comment:
This change is unrelated to metrics, right ?
##########
polaris-service/src/main/java/org/apache/polaris/service/TimedApplicationEventListener.java:
##########
@@ -66,16 +66,16 @@ private class TimedRequestEventListener implements
RequestEventListener {
@Override
public void onEvent(RequestEvent event) {
String realmId =
CallContext.getCurrentContext().getRealmContext().getRealmIdentifier();
- if (event.getType() == RequestEvent.Type.RESOURCE_METHOD_START) {
+ if (event.getType() == RequestEvent.Type.REQUEST_MATCHED) {
Review Comment:
FYI, this listener to `@TimedApi` (populated in mustache template) is not
required with Quarkus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
