andrew4699 commented on code in PR #423: URL: https://github.com/apache/polaris/pull/423#discussion_r1829783635
########## polaris-service/src/main/java/org/apache/polaris/service/ratelimiter/RateLimiterFilter.java: ########## @@ -18,22 +18,17 @@ */ package org.apache.polaris.service.ratelimiter; -import jakarta.annotation.Priority; -import jakarta.servlet.Filter; -import jakarta.servlet.FilterChain; -import jakarta.servlet.ServletException; -import jakarta.servlet.ServletRequest; -import jakarta.servlet.ServletResponse; -import jakarta.servlet.http.HttpServletResponse; -import jakarta.ws.rs.Priorities; +import jakarta.ws.rs.container.ContainerRequestContext; +import jakarta.ws.rs.container.ContainerRequestFilter; import jakarta.ws.rs.core.Response; import java.io.IOException; +import javax.ws.rs.ext.Provider; import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** Request filter that returns a 429 Too Many Requests if the rate limiter says so */ -@Priority(Priorities.AUTHORIZATION + 1) Review Comment: Yes. Previously I don't think it did anything because it was outside Jersey. Also we don't seem to have any Jersey filters so the priority doesn't really matter currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
