eric-maynard commented on code in PR #423:
URL: https://github.com/apache/polaris/pull/423#discussion_r1829821026
##########
polaris-service/src/main/java/org/apache/polaris/service/PolarisApplication.java:
##########
@@ -261,10 +261,7 @@ public void run(PolarisApplicationConfig configuration,
Environment environment)
.addMappingForUrlPatterns(EnumSet.of(DispatcherType.REQUEST), true,
"/*");
if (configuration.getRateLimiter() != null) {
- environment
- .servlets()
- .addFilter("ratelimiter", new
RateLimiterFilter(configuration.getRateLimiter()))
- .addMappingForUrlPatterns(EnumSet.of(DispatcherType.REQUEST), true,
"/*");
+ environment.jersey().register(new
RateLimiterFilter(configuration.getRateLimiter()));
Review Comment:
I get that, but my concern is whether this actually changes the behavior of
the system by rate-limiting less things now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
