andrew4699 commented on code in PR #431:
URL: https://github.com/apache/polaris/pull/431#discussion_r1833142541
##########
polaris-service/src/main/java/org/apache/polaris/service/TimedApplicationEventListener.java:
##########
@@ -38,13 +40,21 @@
@Provider
public class TimedApplicationEventListener implements ApplicationEventListener
{
+ public static final String METRIC_NAME = "polaris.TimedApi";
+ public static final String TAG_API_NAME = "API_NAME";
Review Comment:
I agree, but we currently uppercase the realm/status tags:
https://github.com/apache/polaris/blob/main/polaris-core/src/main/java/org/apache/polaris/core/monitor/PolarisMetricRegistry.java#L45-L46
I'm not sure if we'd want to leave the old tags uppercase or if we want to
change them, how we should handle backward compatibility and eventually full
deprecation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
