andrew4699 commented on code in PR #431:
URL: https://github.com/apache/polaris/pull/431#discussion_r1836997627


##########
polaris-service/src/main/java/org/apache/polaris/service/TimedApplicationEventListener.java:
##########
@@ -38,13 +40,21 @@
 @Provider
 public class TimedApplicationEventListener implements ApplicationEventListener 
{
 
+  public static final String METRIC_NAME = "polaris.TimedApi";
+  public static final String TAG_API_NAME = "API_NAME";

Review Comment:
   Done! The new tags only emit the `snake_case` version and the old ones emit 
both. Added lots of comments about deprecation and beefed up the tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to