collado-mike commented on code in PR #431:
URL: https://github.com/apache/polaris/pull/431#discussion_r1835161052
##########
polaris-service/src/main/java/org/apache/polaris/service/TimedApplicationEventListener.java:
##########
@@ -38,13 +40,21 @@
@Provider
public class TimedApplicationEventListener implements ApplicationEventListener
{
+ public static final String METRIC_NAME = "polaris.TimedApi";
Review Comment:
Can we just make this `polaris.api`? I propose we go with the naming
convention of all lowercase and underscore separated - I feel that's a much
more common metric naming convention than the CamelCase we use here. I think we
can deprecate the old metric names and eventually get rid of them.
##########
polaris-service/src/main/java/org/apache/polaris/service/TimedApplicationEventListener.java:
##########
@@ -38,13 +40,21 @@
@Provider
public class TimedApplicationEventListener implements ApplicationEventListener
{
+ public static final String METRIC_NAME = "polaris.TimedApi";
+ public static final String TAG_API_NAME = "API_NAME";
Review Comment:
Lets use lowercase for the new metrics and deprecate the old ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
