dimas-b commented on code in PR #438:
URL: https://github.com/apache/polaris/pull/438#discussion_r1833573801
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrincipalSecrets.java:
##########
@@ -64,40 +73,78 @@ private String generateRandomHexString(int stringLength) {
return sb.toString();
}
+ private String hashSecret(String secret) {
+ return DigestUtils.sha256Hex(secret + ":" + secretSalt);
Review Comment:
It is probably advisable to use different salt values for each secret (for
the same reason why different salt values are used for different users).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
