eric-maynard commented on code in PR #438:
URL: https://github.com/apache/polaris/pull/438#discussion_r1833575930
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrincipalSecrets.java:
##########
@@ -64,40 +73,78 @@ private String generateRandomHexString(int stringLength) {
return sb.toString();
}
+ private String hashSecret(String secret) {
+ return DigestUtils.sha256Hex(secret + ":" + secretSalt);
Review Comment:
I am actually not clear on why/if we need two secrets per user.
If we turn out to only want to use one, then just having the one salt is
fine. If we are really using both secrets, then probably having two salts for
the two secrets is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
