eric-maynard commented on code in PR #435:
URL: https://github.com/apache/polaris/pull/435#discussion_r1841619831


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/MetaStoreManagerFactory.java:
##########
@@ -33,7 +32,7 @@
  * configuration
  */
 @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY, 
property = "type")
-public interface MetaStoreManagerFactory extends Discoverable {

Review Comment:
   The changes look good to me, but the test doesn't include any configs 
specific to that implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to