adutra commented on code in PR #435:
URL: https://github.com/apache/polaris/pull/435#discussion_r1842390335
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/MetaStoreManagerFactory.java:
##########
@@ -33,7 +32,7 @@
* configuration
*/
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY,
property = "type")
-public interface MetaStoreManagerFactory extends Discoverable {
Review Comment:
I think he meant to enhance the test with some fields populated through
configuration:
```java
@Nested
class EclipseLinkMetastore {
private final DropwizardAppExtension<PolarisApplicationConfig> app =
new DropwizardAppExtension<>(
PolarisApplication.class,
CONFIG_PATH,
RANDOM_APP_PORT,
RANDOM_ADMIN_PORT,
ConfigOverride.config("metaStoreManager.type", "eclipse-link"),
ConfigOverride.config("metaStoreManager.persistence-unit",
"test"),
ConfigOverride.config("metaStoreManager.conf-file",
"/path/to/persistence.xml"));
@Test
void testMetastoreType() {
assertThat(app.getConfiguration().getMetaStoreManagerFactory())
.asInstanceOf(type(EclipseLinkPolarisMetaStoreManagerFactory.class))
.extracting("persistenceUnitName", "confFile")
.containsExactly("test", "/path/to/persistence.xml");
}
}
```
(you need to switch the eclipse-link dependency from `testRuntimeOnly` to
`testImplementation`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
