sfc-gh-aguterman commented on code in PR #534:
URL: https://github.com/apache/polaris/pull/534#discussion_r1880717344
##########
dropwizard/service/src/test/java/org/apache/polaris/service/ratelimiter/TokenBucketResultAsserter.java:
##########
@@ -18,25 +18,26 @@
*/
package org.apache.polaris.service.ratelimiter;
+import java.util.function.BooleanSupplier;
import org.junit.jupiter.api.Assertions;
/** Utility class for testing rate limiters. Lets you easily assert the result
of tryAcquire(). */
-public class RateLimitResultAsserter {
- private final RateLimiter rateLimiter;
+public class TokenBucketResultAsserter {
Review Comment:
I don't think it makes sense to refactor this class specifically. In
isolation, making repeated assertions on a BooleanSupplier seems like a code
smell. The expectation that the boolean will change is coupled to the fact that
the BooleanSupplier is a RateLimiter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
