adutra commented on code in PR #534:
URL: https://github.com/apache/polaris/pull/534#discussion_r1880769657
##########
dropwizard/service/src/main/java/org/apache/polaris/service/dropwizard/config/PolarisApplicationConfig.java:
##########
@@ -333,6 +338,17 @@ public void setRateLimiter(@Nullable RateLimiter
rateLimiter) {
this.rateLimiter = rateLimiter;
}
+ @JsonProperty("tokenBucketFactory")
+ private TokenBucketFactory getTokenBucketFactory() {
+ return tokenBucketFactory;
+ }
+
+ @JsonProperty("tokenBucketFactory")
+ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include =
JsonTypeInfo.As.PROPERTY, property = "type")
+ public void setTokenBucketFactory(@Nullable TokenBucketFactory
tokenBucketFactory) {
+ this.tokenBucketFactory = tokenBucketFactory;
+ }
+
Review Comment:
I tried but I'm afraid that it won't be achievable with Dropwizard
configuration system + HK2 dependency injection.
BTW we already have the same situation: `DefaultPolarisAuthenticator`
requires a `TokenBrokerFactory`, but
`TestInlineBearerTokenPolarisAuthenticator` doesn't – if you use the latter,
the `tokenBroker` configuration section would be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
