sfc-gh-aguterman commented on code in PR #534:
URL: https://github.com/apache/polaris/pull/534#discussion_r1880724171
##########
dropwizard/service/src/main/java/org/apache/polaris/service/dropwizard/config/PolarisApplicationConfig.java:
##########
@@ -333,6 +338,17 @@ public void setRateLimiter(@Nullable RateLimiter
rateLimiter) {
this.rateLimiter = rateLimiter;
}
+ @JsonProperty("tokenBucketFactory")
+ private TokenBucketFactory getTokenBucketFactory() {
+ return tokenBucketFactory;
+ }
+
+ @JsonProperty("tokenBucketFactory")
+ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include =
JsonTypeInfo.As.PROPERTY, property = "type")
+ public void setTokenBucketFactory(@Nullable TokenBucketFactory
tokenBucketFactory) {
+ this.tokenBucketFactory = tokenBucketFactory;
+ }
+
Review Comment:
Is there a way to scope this config down to the RealmTokenBucketRateLimiter
itself? Otherwise the tokenBucketFactory can be unused if you're using a
different limiter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
