adutra commented on code in PR #631:
URL: https://github.com/apache/polaris/pull/631#discussion_r1908349222
##########
dropwizard/service/src/test/java/org/apache/polaris/service/dropwizard/PolarisApplicationIntegrationTest.java:
##########
@@ -722,7 +722,7 @@ public void testRequestBodyTooLarge() {
.header(REALM_PROPERTY_KEY, realm)
.post(largeRequest)) {
assertThat(response)
- .returns(Response.Status.BAD_REQUEST.getStatusCode(),
Response::getStatus)
+ .returns(Response.Status.REQUEST_ENTITY_TOO_LARGE.getStatusCode(),
Response::getStatus)
Review Comment:
IMHO we do need to take connection closed into account. With Quarkus for
sure, maybe even with Dropwizard. From my recollection and manual testing, both
frameworks close the connection on this response error. The problem is that
sometimes the client receives the response payload before the connection is
closed, sometimes after. Again from my recollection, in Quarkus, 1 execution
out of 3 or 4 ends up with connection closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
