dimas-b commented on code in PR #631:
URL: https://github.com/apache/polaris/pull/631#discussion_r1908916140
##########
dropwizard/service/src/test/java/org/apache/polaris/service/dropwizard/PolarisApplicationIntegrationTest.java:
##########
@@ -722,7 +722,7 @@ public void testRequestBodyTooLarge() {
.header(REALM_PROPERTY_KEY, realm)
.post(largeRequest)) {
assertThat(response)
- .returns(Response.Status.BAD_REQUEST.getStatusCode(),
Response::getStatus)
+ .returns(Response.Status.REQUEST_ENTITY_TOO_LARGE.getStatusCode(),
Response::getStatus)
Review Comment:
RFC 9110 defines the protocol-level behaviour, but in Polaris, the REST
endpoint produces a response object with a status code in this case. I would
not think Quarkus closing the connection prematurely would be correct. I
believe Quarkus (or any other Web App framework) ought to send the response
object to the client.
@adutra : are you sure the connection resets happened in the "body" test and
and not in the "header" test? The headers are handled by the Web Apop
framework, so the connection reset decision lies with the framework itself.
Still, the error on large payload objects is handled differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
