adutra commented on code in PR #631:
URL: https://github.com/apache/polaris/pull/631#discussion_r1908953673
##########
dropwizard/service/src/test/java/org/apache/polaris/service/dropwizard/PolarisApplicationIntegrationTest.java:
##########
@@ -722,7 +722,7 @@ public void testRequestBodyTooLarge() {
.header(REALM_PROPERTY_KEY, realm)
.post(largeRequest)) {
assertThat(response)
- .returns(Response.Status.BAD_REQUEST.getStatusCode(),
Response::getStatus)
+ .returns(Response.Status.REQUEST_ENTITY_TOO_LARGE.getStatusCode(),
Response::getStatus)
Review Comment:
> are you sure the connection resets happened in the "body" test and and not
in the "header" test?
Yes 😄 – those two tests gave me enough headaches that I still remember...
> The headers are handled by the Web Apop framework,
In Quarkus, both cases are handled by Vertx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
