dimas-b commented on code in PR #786:
URL: https://github.com/apache/polaris/pull/786#discussion_r1917142626
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusRestCatalogIntegrationTest.java:
##########
@@ -19,7 +19,21 @@
package org.apache.polaris.service.quarkus.it;
import io.quarkus.test.junit.QuarkusTest;
+import io.quarkus.test.junit.QuarkusTestProfile;
+import io.quarkus.test.junit.TestProfile;
+import java.util.Map;
import org.apache.polaris.service.it.test.PolarisRestCatalogIntegrationTest;
@QuarkusTest
-public class QuarkusRestCatalogIntegrationTest extends
PolarisRestCatalogIntegrationTest {}
+@TestProfile(QuarkusRestCatalogIntegrationTest.Profile.class)
+public class QuarkusRestCatalogIntegrationTest extends
PolarisRestCatalogIntegrationTest {
Review Comment:
Sorry, I'm a bit confused wrt #778 ... Was it not moved to
`QuarkusRestCatalogIT`?
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java:
##########
@@ -96,6 +96,12 @@
/**
* Import the full core Iceberg catalog tests by hitting the REST service via
the RESTCatalog
* client.
+ *
+ * @implSpec @implSpec This test expects the server to be configured with the
following features
+ * enabled:
Review Comment:
nit: disabled?
##########
quarkus/service/src/main/resources/application.properties:
##########
@@ -120,30 +120,18 @@
polaris.authentication.token-broker.max-token-generation=PT1H
# polaris.storage.gcp.token=token
# polaris.storage.gcp.lifespan=PT1H
+# Profile for unit tests
%test.quarkus.log.file.enable=false
-%test.quarkus.log.category."org.apache.polaris".level=INFO
-%test.quarkus.log.category."org.apache.iceberg.rest".level=INFO
-%test.quarkus.log.category."org.apache.iceberg.rest.RESTSessionCatalog".level=ERROR
-%test.quarkus.log.category."org.apache.polaris.core.persistence.PolarisMetaStoreManagerImpl".level=ERROR
-%test.quarkus.log.category."org.apache.polaris.service.context.DefaultRealmContextResolver".level=ERROR
-%test.quarkus.log.category."org.apache.polaris.service.catalog.PolarisCatalogHandlerWrapper".level=ERROR
-%test.quarkus.log.category."org.apache.polaris.service.storage.PolarisStorageIntegrationProviderImpl".level=ERROR
-%test.quarkus.http.limits.max-body-size=1000000
%test.quarkus.otel.sdk.disabled=true
-%test.polaris.authentication.token-broker.type=symmetric-key
-%test.polaris.authentication.token-broker.symmetric-key.secret=polaris
-%test.polaris.features.defaults."ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING"=false
-%test.polaris.features.defaults."ALLOW_EXTERNAL_METADATA_FILE_LOCATION"=false
-%test.polaris.features.defaults."ALLOW_OVERLAPPING_CATALOG_URLS"=true
-%test.polaris.features.defaults."ALLOW_SPECIFYING_FILE_IO_IMPL"=true
-%test.polaris.features.defaults."ALLOW_WILDCARD_LOCATION"=true
-%test.polaris.features.defaults."ENFORCE_PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_CHECKING"=true
-%test.polaris.features.defaults."INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST"=true
-%test.polaris.features.defaults."SKIP_CREDENTIAL_SUBSCOPING_INDIRECTION"=true
-%test.polaris.features.defaults."SUPPORTED_CATALOG_STORAGE_TYPES"=["FILE","S3","GCS","AZURE"]
-%test.polaris.realm-context.realms=POLARIS
-%test.polaris.realm-context.type=test
-%test.polaris.storage.aws.access-key=accessKey
-%test.polaris.storage.aws.secret-key=secretKey
-%test.polaris.storage.gcp.token=token
-%test.polaris.storage.gcp.lifespan=PT1H
+
+# Profile for integration tests
+%it.quarkus.http.limits.max-body-size=1000000
+%it.polaris.features.defaults."ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING"=false
+%it.polaris.features.defaults."ALLOW_EXTERNAL_METADATA_FILE_LOCATION"=false
+%it.polaris.features.defaults."ALLOW_OVERLAPPING_CATALOG_URLS"=true
+%it.polaris.features.defaults."ALLOW_SPECIFYING_FILE_IO_IMPL"=true
+%it.polaris.features.defaults."ALLOW_WILDCARD_LOCATION"=true
+%it.polaris.features.defaults."ENFORCE_PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_CHECKING"=true
+%it.polaris.features.defaults."INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_it"=true
+%it.polaris.features.defaults."SKIP_CREDENTIAL_SUBSCOPING_INDIRECTION"=true
+%it.polaris.features.defaults."SUPPORTED_CATALOG_STORAGE_TYPES"=["FILE","S3","GCS","AZURE"]
Review Comment:
Would it be possible to keep these settings in a java test profile? IIRC,
`application.properties` is embedded in the final distribution jar, so it would
be nice to avoid having test stuff there.
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisApplicationIntegrationTest.java:
##########
@@ -93,6 +93,18 @@
import org.junit.jupiter.api.TestInfo;
import org.junit.jupiter.api.extension.ExtendWith;
+/**
+ * @implSpec This test expects the server to be configured with the following
features enabled:
Review Comment:
WDYT about putting these notes in a README under `integration-test` and
mention the README in javadoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
