adutra commented on code in PR #786:
URL: https://github.com/apache/polaris/pull/786#discussion_r1918088608
##########
build.gradle.kts:
##########
@@ -91,6 +91,8 @@ tasks.named<RatTask>("rat").configure {
excludes.add("logs/**")
excludes.add("service/common/src/**/banner.txt")
excludes.add("quarkus/service/logs")
+ excludes.add("quarkus/server/logs")
+ excludes.add("quarkus/admin/logs")
Review Comment:
Well, it's about testing the "real thing". If the real thing produces log
files, then let it be. At least you can inspect the log files manually to check
e.g. if a change you made produced some expected output in the log files.
Do you think it's not worth it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
