adutra commented on code in PR #786:
URL: https://github.com/apache/polaris/pull/786#discussion_r1918085943


##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusRestCatalogIntegrationTest.java:
##########
@@ -19,7 +19,21 @@
 package org.apache.polaris.service.quarkus.it;
 
 import io.quarkus.test.junit.QuarkusTest;
+import io.quarkus.test.junit.QuarkusTestProfile;
+import io.quarkus.test.junit.TestProfile;
+import java.util.Map;
 import org.apache.polaris.service.it.test.PolarisRestCatalogIntegrationTest;
 
 @QuarkusTest
-public class QuarkusRestCatalogIntegrationTest extends 
PolarisRestCatalogIntegrationTest {}
+@TestProfile(QuarkusRestCatalogIntegrationTest.Profile.class)
+public class QuarkusRestCatalogIntegrationTest extends 
PolarisRestCatalogIntegrationTest {

Review Comment:
   Because it can be useful to also run those `*IntegrationTest` when running 
`./gradlew test` – they usually run faster, because there is no need to build 
the artifact first.
   
   In Maven, it's common to have the following idiom:
   
   ```java
   @QuarkusTest
   public class FooTest {
   // tests go here
   }
   
   @QuarkusIntegrationTest
   public class FooIT extends FooTest {}
   ````
   
   (this doesn't work in Gradle though)
   
   But if you prefer, I can remove the tests in `test` and only keep the ones 
in `intTest`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to