adutra commented on code in PR #626:
URL: https://github.com/apache/polaris/pull/626#discussion_r1930207183


##########
helm/polaris/templates/tests/test-connection.yaml:
##########
@@ -35,5 +35,7 @@ spec:
     - name: wget
       image: busybox
       command: ['wget']
-      args: ['{{ include "polaris.fullname" . }}:{{ index 
.Values.service.ports "polaris-metrics" }}/q/health']
+      args:
+        - --spider
+        - '{{ include "polaris.fullnameWithSuffix" (list . "mgmt") }}:{{ get 
(first .Values.managementService.ports) "port" }}/q/health/ready'
   restartPolicy: Never

Review Comment:
   Hmm it wasn't failing for me, the test pod always comes up _after_ the 
Polaris pod reaches ready state.
   
   I don't mind changing but waiting 30 seconds seems a lot, how about we poll 
the health endpoint X times until it succeeds?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to