MonkeyCanCode commented on code in PR #626:
URL: https://github.com/apache/polaris/pull/626#discussion_r1930665495
##########
.github/workflows/helm.yml:
##########
@@ -99,7 +99,7 @@ jobs:
if: steps.list-changed.outputs.changed == 'true'
run: |
eval $(minikube -p minikube docker-env)
- ./gradlew :polaris-quarkus-server:assemble \
+ ./gradlew :polaris-quarkus-server:assemble
:polaris-quarkus-admin:assemble \
-Dquarkus.container-image.build=true \
-PeclipseLinkDeps=com.h2database:h2:2.3.232
Review Comment:
Yes, I was using this branch for testing and bootstrap is probably hitting
in-memory persistency for h2database i think? I also agreed we should use
somewhat real db people may be using (e.g. Postgres) instead of using
h2database (kinds left people to think this project is not close to ready to be
use).
The latest main branch seems to be pretty stable (I only did some basic
testing...planning to do more later this weekend). So maybe good to introduce
those changes now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
