adutra commented on code in PR #626: URL: https://github.com/apache/polaris/pull/626#discussion_r1930309191
########## helm/polaris/README.md: ########## @@ -45,41 +45,105 @@ A Helm chart for Polaris. ### Optional -When using a custom `persistence.xml`, a Kubernetes Secret must be created for `.persistenceConfigSecret`. Below is a sample command: +When using a custom `persistence.xml`, a Kubernetes Secret must be created for it. Below is a sample command: ```bash kubectl create secret generic polaris-secret -n polaris --from-file=persistence.xml ``` ### From local directory (for development purposes) -From Polaris repo root: +The below instructions assume Minikube is running and Helm is installed. + +If necessary, load the Docker images into Minikube: + +```bash +eval $(minikube -p minikube docker-env) Review Comment: Ah that's true. Well, let's mention both! I will add a note about Kind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
