dimas-b commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1931421167
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -2039,8 +1975,7 @@ private List<TableIdentifier>
listTableLike(PolarisEntitySubType subType, Namesp
* @return FileIO object
*/
private FileIO loadFileIO(String ioImpl, Map<String, String> properties) {
- Map<String, String> propertiesWithS3CustomizedClientFactory = new
HashMap<>(properties);
- return fileIOFactory.loadFileIO(ioImpl,
propertiesWithS3CustomizedClientFactory);
+ return CatalogUtil.loadFileIO(ioImpl, properties, new Configuration());
Review Comment:
I appreciate the effort to remove test-scoped methods from `FileIOFactory`,
but I do not think this change is worth keeping in the long run. This call path
by-passes the factory, which IMO is worse that having extra methods in the
factory interface.
I think this needs some more follow-up refactoring. In the interest of
making progress and considering that this method is covered by a "test-only"
option, I'm approving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
