sfc-gh-rxing commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1932929000
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -2039,8 +1975,7 @@ private List<TableIdentifier>
listTableLike(PolarisEntitySubType subType, Namesp
* @return FileIO object
*/
private FileIO loadFileIO(String ioImpl, Map<String, String> properties) {
- Map<String, String> propertiesWithS3CustomizedClientFactory = new
HashMap<>(properties);
- return fileIOFactory.loadFileIO(ioImpl,
propertiesWithS3CustomizedClientFactory);
+ return CatalogUtil.loadFileIO(ioImpl, properties, new Configuration());
Review Comment:
Thanks for reviewing this PR! I also refactored the TestServices:
1. Move it to polaris-service-common module
2. Allow us to provide some custom objects when creating the services.
Hopefully it can be helpful for our testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
