dimas-b commented on code in PR #955:
URL: https://github.com/apache/polaris/pull/955#discussion_r1947319680
##########
api/management-model/build.gradle.kts:
##########
@@ -54,12 +58,26 @@ openApiGenerate {
serverVariables = mapOf("basePath" to "api/v1")
}
-listOf("sourcesJar", "compileJava").forEach { task ->
- tasks.named(task) { dependsOn("openApiGenerate") }
-}
-
sourceSets {
main { java {
srcDir(project.layout.buildDirectory.dir("generated/src/main/java")) } }
+ test { java { srcDir("src/test/java") } }
+}
+
+listOf("sourcesJar", "compileJava").forEach { task ->
+ tasks.named(task) { dependsOn("openApiGenerate") }
}
tasks.named("javadoc") { dependsOn("jandex") }
+
+tasks.named<JavaCompile>("compileTestJava") { dependsOn("openApiGenerate") }
+
+tasks.named<Test>("test") { dependsOn("openApiGenerate") }
+
+tasks.withType<Test> {
+ useJUnitPlatform()
+ testLogging {
+ events("passed", "skipped", "failed")
+ showStandardStreams = true
+ }
+ dependsOn("openApiGenerate")
+}
Review Comment:
This change is not necessary AFAIK
##########
api/management-model/build.gradle.kts:
##########
@@ -54,12 +57,26 @@ openApiGenerate {
serverVariables = mapOf("basePath" to "api/v1")
}
-listOf("sourcesJar", "compileJava").forEach { task ->
- tasks.named(task) { dependsOn("openApiGenerate") }
Review Comment:
I believe only the new `testImplementation` depedencies and `test { java {
srcDir("src/test/java") } }` are needed. All other build script changes seem to
be superfluous - please remove them to keep the scripts lean.
##########
spec/polaris-management-service.yml:
##########
@@ -796,6 +796,13 @@ components:
- INTERNAL
- EXTERNAL
description: the type of catalog - internal or external
+ x-java-field-annotations: >-
Review Comment:
Please remove this change. I do not think it is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
