mmgaggle commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1952780004
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisCredentialProperty.java:
##########
@@ -23,6 +23,8 @@ public enum PolarisCredentialProperty {
AWS_KEY_ID(String.class, "s3.access-key-id", "the aws access key id"),
AWS_SECRET_KEY(String.class, "s3.secret-access-key", "the aws access key
secret"),
AWS_TOKEN(String.class, "s3.session-token", "the aws scoped access token"),
+ AWS_ENDPOINT(String.class, "s3.endpoint", "the aws s3 endpoint"),
+ AWS_PATH_STYLE_ACCESS(Boolean.class, "s3.path-style-access", "the aws s3
path style access"),
Review Comment:
For IBM's watsonx.data product it is set to `true` by default for Minio and
Ceph bucket types, reason being that it's more likely to work. Path style will
work regardless of whether the customer has setup wildcard DNS, a TLS
certificate with a subject-alternate-name (the wildcard), and the hostname in
the zonegroup (for Ceph). Virtual host style will only work if all of those
things are done.
It's not a hill I would die on, but it's worthy of consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
