lefebsy commented on code in PR #389: URL: https://github.com/apache/polaris/pull/389#discussion_r1953509365
########## polaris-core/src/main/java/org/apache/polaris/core/storage/s3compatible/S3CompatibleCredentialsStorageIntegration.java: ########## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.storage.s3compatible; + +import java.net.URI; +import java.util.EnumMap; +import java.util.Set; +import org.apache.polaris.core.PolarisDiagnostics; +import org.apache.polaris.core.storage.InMemoryStorageIntegration; +import org.apache.polaris.core.storage.PolarisCredentialProperty; +import org.apache.polaris.core.storage.s3compatible.S3CompatibleStorageConfigurationInfo.CredsCatalogAndClientStrategyEnum; +import org.jetbrains.annotations.NotNull; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import software.amazon.awssdk.auth.credentials.AwsBasicCredentials; +import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider; +import software.amazon.awssdk.regions.Region; +import software.amazon.awssdk.services.sts.StsClient; +import software.amazon.awssdk.services.sts.StsClientBuilder; +import software.amazon.awssdk.services.sts.model.AssumeRoleRequest; +import software.amazon.awssdk.services.sts.model.AssumeRoleResponse; + +/** Credential vendor that supports generating */ +public class S3CompatibleCredentialsStorageIntegration + extends InMemoryStorageIntegration<S3CompatibleStorageConfigurationInfo> { + private static final Logger LOGGER = + LoggerFactory.getLogger(S3CompatibleCredentialsStorageIntegration.class); + private StsClient stsClient; + + public S3CompatibleCredentialsStorageIntegration() { + super(S3CompatibleCredentialsStorageIntegration.class.getName()); + } + + public void createStsClient(S3CompatibleStorageConfigurationInfo s3storageConfig) { + + LOGGER.debug("S3Compatible - createStsClient()"); + StsClientBuilder stsBuilder = software.amazon.awssdk.services.sts.StsClient.builder(); + stsBuilder.region( + Region + .US_WEST_1); // default region to avoid bug, because most (all?) S3 compatible softwares + // do not care about regions + stsBuilder.endpointOverride( + URI.create( + s3storageConfig + .getS3Endpoint())); // S3Compatible - AWS STS endpoint is unique and different from + // the S3 Endpoint + stsBuilder.credentialsProvider( + StaticCredentialsProvider.create( + AwsBasicCredentials.create( + s3storageConfig.getS3CredentialsCatalogAccessKeyId(), + s3storageConfig.getS3CredentialsCatalogSecretAccessKey()))); + this.stsClient = stsBuilder.build(); + LOGGER.debug("S3Compatible - stsClient successfully built"); + } + + /** {@inheritDoc} */ + @Override + public EnumMap<PolarisCredentialProperty, String> getSubscopedCreds( + @NotNull PolarisDiagnostics diagnostics, + @NotNull S3CompatibleStorageConfigurationInfo storageConfig, + boolean allowListOperation, + @NotNull Set<String> allowedReadLocations, + @NotNull Set<String> allowedWriteLocations) { + + LOGGER.debug("S3Compatible - getSubscopedCreds - applying credential strategy"); + EnumMap<PolarisCredentialProperty, String> propertiesMap = + new EnumMap<>(PolarisCredentialProperty.class); + propertiesMap.put(PolarisCredentialProperty.AWS_ENDPOINT, storageConfig.getS3Endpoint()); + propertiesMap.put( + PolarisCredentialProperty.AWS_PATH_STYLE_ACCESS, + storageConfig.getS3PathStyleAccess().toString()); Review Comment: I trust you that there is probably a simple way to do this. But I just failed to find how to access this stuff, even after hours of inspecting context properties in debug session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
