andrew4699 commented on code in PR #1046:
URL: https://github.com/apache/polaris/pull/1046#discussion_r1966372170
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -2014,6 +2025,12 @@ private Boolean getBooleanContextConfiguration(String
configKey, boolean default
* @return true if the exception is retryable
*/
private static boolean isStorageProviderRetryableException(Exception ex) {
+ if (ex instanceof RuntimeException rex
+ && !RETRYABLE_CLOUD_EXCEPTION_CODES.contains(
+ IcebergExceptionMapper.extractHttpCodeFromCloudException(rex))) {
Review Comment:
That's a fair point. I changed it to use the retryable property for AWS/GCP.
Azure doesn't have one though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
