flyrain commented on code in PR #1046:
URL: https://github.com/apache/polaris/pull/1046#discussion_r1972139812
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -264,4 +264,13 @@ public static <T> Builder<T> builder() {
+ STORAGE_CREDENTIAL_DURATION_SECONDS.key)
.defaultValue(30 * 60) // 30 minutes
.build();
+
+ // The default value is kept at 12 for backward compatibility
+ public static final PolarisConfiguration<Integer>
MAX_METADATA_REFRESH_RETRIES =
+ PolarisConfiguration.<Integer>builder()
+ .key("MAX_METADATA_REFRESH_RETRIES")
+ .description(
+ "How many times to retry refreshing metadata when the previous
error was retryable")
+ .defaultValue(12)
+ .build();
Review Comment:
> Do you mean setting this in one of the k8s/application properties files?
I was talking about the Snowfalke's Polaris deployment.
> I'd be surprised if anyone is getting benefit from it being so high.
I believe not. The only compatibility concern is the current production
deployment, including Snowflake, Zsaler, etc. Given that we don't have a
release yet, the impact will manageable. In general, it should be fine to
prefer a reasonable retry number(2 or 3) to compatibility. cc @MonkeyCanCode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
