singhpk234 commented on code in PR #1046:
URL: https://github.com/apache/polaris/pull/1046#discussion_r1968291406
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -264,4 +264,13 @@ public static <T> Builder<T> builder() {
+ STORAGE_CREDENTIAL_DURATION_SECONDS.key)
.defaultValue(30 * 60) // 30 minutes
.build();
+
+ // The default value is kept at 12 for backward compatibility
+ public static final PolarisConfiguration<Integer>
MAX_METADATA_REFRESH_RETRIES =
+ PolarisConfiguration.<Integer>builder()
+ .key("MAX_METADATA_REFRESH_RETRIES")
+ .description(
+ "How many times to retry refreshing metadata when the previous
error was retryable")
+ .defaultValue(12)
+ .build();
Review Comment:
I agree with the backward compatibility,
[doubt] These retries are on top of SDK retries ?
why are we did we go with a such high number ? default for hive catalog impl
is 2 more details
: https://github.com/apache/iceberg/pull/5510#issuecomment-1226712167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
